Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've made a strategic decision to improve the developer experience (DX) within the
temporal/sdk
PHP package rather than in the integration bridge package itself. This approach simplifies the structure and focuses on making the SDK more user-friendly for developers.The
spiral/temporal-bridge
package will now primarily serve to facilitate the integration with the Spiral framework, avoiding additional complexities. This streamlines the overall setup and usage.In addition, we've revised the way Workflow and Activity classes are created. Instead of generating both a class and an interface for these, we're now only creating the class. This simplification makes the process more straightforward and efficient.
Here are the updated examples for Activity and Workflow classes in PHP:
For an Activity class:
Command:
Result:
For a Workflow class:
Command:
php app.php create:workflow Payment --query-method=getPayment:string' --query-method=getTotal:int --signal-method=pay
Result:
Additionally, we've removed presets from the package. This decision was made because presets are often specific to particular applications and trying to accommodate all potential scenarios was becoming overly complex.